-
Notifications
You must be signed in to change notification settings - Fork 82
test: batch 2 conformity tests #4110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Test Results 20 files ±0 265 suites ±0 18m 21s ⏱️ -12s Results for commit 9356d97. ± Comparison against base commit 6cbad23. This pull request removes 2 tests.
♻️ This comment has been updated with latest results. |
fc27453
to
c418d07
Compare
1fb8c97
to
c418d07
Compare
Looks like there's a lint issue. |
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
3ca251a
to
13e8db2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, left one question
Yes, I just uncommented some previously commented code, but it’s a good chance to clean it up as well. |
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
defafa7
to
65694d3
Compare
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
5236768
to
9356d97
Compare
I am slighlty confused by the description. Batch 2 was deleted or? May you update the description to something more informative |
@konstantinabl sure! Is current description good enough: |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4110 +/- ##
==========================================
+ Coverage 95.39% 95.67% +0.27%
==========================================
Files 122 121 -1
Lines 20996 20103 -893
Branches 1750 1739 -11
==========================================
- Hits 20030 19233 -797
+ Misses 944 845 -99
- Partials 22 25 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
@arianejasuwienas absolutely, reviewing now : ) thanks! |
Description
We commented out batch 2–5 conformity tests after they broke due to changes in batch 1.
This PR restores them by uncommenting and adjusting for the batch 1 updates.
Additionally, some Codacy suggestions for the uncommented code have been applied.
Related issue(s)
Fixes #3823
Testing Guide
Changes from original design (optional)
Additional work needed (optional)
Checklist